Make SqlScaleMonitor and SqlScaleMetric public for Scale Controller Redesign#139
Merged
cgillum merged 1 commit intomicrosoft:mainfrom Jan 13, 2023
Merged
Conversation
cgillum
approved these changes
Jan 13, 2023
chiangvincent
added a commit
to chiangvincent/durabletask-mssql
that referenced
this pull request
Jan 17, 2023
microsoft#139)" This reverts commit fea462e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently redesigning the scale controller to unify the duplicate scaling logic that resides in each of the extensions (CosmosDB, ServiceBus, EventHubs, Storage, etc.) and the scale controller. As a part of this redesign, scale controller will directly instantiate the ScaleMonitors for each of the above extensions, and call into the GetMetricsAsync and GetScaleStatus methods directly. To support this, we need to make ScaleMonitors, and any dependent classes public in each of the extensions.
Resources: